Skip to content

Commit

Permalink
Adjust xfail mark: xfail if no GPU (on CI)
Browse files Browse the repository at this point in the history
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
  • Loading branch information
lebrice committed Nov 21, 2024
1 parent 2695cf8 commit 9ed0634
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions project/algorithms/jax_ppo_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import dataclasses
import functools
import operator
import sys
import time
from collections.abc import Callable, Iterable, Sequence
from logging import getLogger
Expand Down Expand Up @@ -206,7 +205,7 @@ def test_ours_with_trainer(
algo.visualize(ts_i, gif_path=gif_path, eval_rng=eval_rng_i)


@pytest.mark.xfail(sys.platform == "darwin" and IN_GITHUB_CI, reason="Fails on macOS in CI.")
@pytest.mark.xfail(not torch.cuda.is_available(), reason="Fails on CPU in the CI")
def test_results_are_same_with_or_without_jax_trainer(
results_ours: tuple[PPOState, EvalMetrics],
results_ours_with_trainer: tuple[PPOState, EvalMetrics],
Expand Down

0 comments on commit 9ed0634

Please sign in to comment.