Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify typing, remove uses of the Algorithm class #32

Merged
merged 26 commits into from
Jul 15, 2024
Merged

Simplify typing, remove uses of the Algorithm class #32

merged 26 commits into from
Jul 15, 2024

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Jul 8, 2024

No description provided.

@lebrice lebrice linked an issue Jul 8, 2024 that may be closed by this pull request
Reduce typing verbosity and simplify/remove generic classes #30
Closed
@lebrice lebrice marked this pull request as ready for review July 9, 2024 14:25
lebrice added 26 commits July 15, 2024 14:28
@lebrice
Rename jax_algo.py to jax_example.py
48cddb9 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Simplify Example algo, remove Algorithm as base
90af250 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Remove Algorithm base from Jax example algo
cd634ae 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Remove use of the Algorithm class in all algos
a8478e0 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Make Algorithm a protocol class
c5022e2 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix import bug with Algorithm class
bbca437 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
fixup! Remove use of the Algorithm class in all algos
9b17a3c
@lebrice
Fix bug in main_test.py
48dc292 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix issue with config name for jax example
39229ee 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Rename example_algo.py to example.py
d9b3cf9 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Move test classes to a new testsuites folder
708be9e 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Remove Algorithm class use from callback.py
82586f4 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Remove other references to Algorithm class
d2e7d08 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Move Algorithm to the testsuites folder
cc05775 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Rename Jax example, remove PhaseStr
da3897c 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Remove the "manual optimization" example
62eb0d5 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Clean up the configs for algorithms
7a10095 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Create dyn. configs for optimizers and schedulers
4ece1d5 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix a bug in hydra-zen for inner classes
1218eb2 
- Adds a patch for mit-ll-responsible-ai/hydra-zen#705

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix the no_op algo constructor
23a1ab7 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix the configs for algorithms
b764ce3 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix uses of the algorithm config name in tests
17953f1 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Add tests for the optimizer & lr_scheduler configs
8fe9008 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix issues with dynamic configs
98cc9c1 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix issue with instantiate in hydra_utils
b15e62c 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix issue with required args in configs
e60f022 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 82.60870% with 60 lines in your changes missing coverage. Please review.

Project coverage is 57.06%. Comparing base (d4891fb) to head (e60f022).

Files Patch % Lines
project/algorithms/example.py 63.09% 31 Missing ⚠️
project/algorithms/jax_example.py 69.23% 8 Missing ⚠️
project/algorithms/no_op.py 42.85% 8 Missing ⚠️
project/experiment.py 69.56% 7 Missing ⚠️
project/algorithms/callbacks/samples_per_second.py 80.00% 1 Missing ⚠️
project/algorithms/testsuites/algorithm.py 90.90% 1 Missing ⚠️
project/algorithms/testsuites/algorithm_tests.py 92.30% 1 Missing ⚠️
project/configs/algorithm/lr_scheduler/__init__.py 95.45% 1 Missing ⚠️
project/configs/algorithm/optimizer/__init__.py 95.45% 1 Missing ⚠️
project/utils/hydra_utils.py 95.83% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   56.69%   57.06%   +0.36%     
==========================================
  Files          50       50              
  Lines        3277     3326      +49     
==========================================
+ Hits         1858     1898      +40     
- Misses       1419     1428       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lebrice lebrice merged commit 0d35a38 into master Jul 15, 2024
6 checks passed
@lebrice lebrice deleted the simplify_typing branch July 15, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce typing verbosity and simplify/remove generic classes
2 participants
@lebrice @codecov-commenter