Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an RL example in Jax #55

Merged
merged 54 commits into from
Oct 11, 2024
Merged

Add an RL example in Jax #55

merged 54 commits into from
Oct 11, 2024

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Sep 30, 2024

No description provided.

@lebrice lebrice force-pushed the lebrice/jax-rl-example branch 2 times, most recently from 1252f99 to 3fa1a6d Compare October 2, 2024 19:56
@lebrice lebrice marked this pull request as ready for review October 3, 2024 22:15
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 86.33819% with 122 lines in your changes missing coverage. Please review.

Project coverage is 80.90%. Comparing base (cf197f8) to head (fac9cf2).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
project/algorithms/jax_rl_example_test.py 79.66% 61 Missing ⚠️
project/algorithms/jax_rl_example.py 93.02% 24 Missing ⚠️
project/trainers/jax_trainer.py 89.22% 18 Missing ⚠️
project/algorithms/callbacks/samples_per_second.py 41.66% 7 Missing ⚠️
project/main.py 0.00% 5 Missing ⚠️
project/conftest.py 78.94% 4 Missing ⚠️
project/utils/typing_utils/jax_typing_utils.py 90.90% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   79.28%   80.90%   +1.61%     
==========================================
  Files          61       66       +5     
  Lines        3597     4457     +860     
==========================================
+ Hits         2852     3606     +754     
- Misses        745      851     +106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lebrice lebrice force-pushed the lebrice/jax-rl-example branch 3 times, most recently from 2fcb88e to f845cfe Compare October 7, 2024 20:26
lebrice added 23 commits October 9, 2024 13:05
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
lebrice added 22 commits October 9, 2024 13:05
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice lebrice force-pushed the lebrice/jax-rl-example branch from 0990cef to 2728208 Compare October 9, 2024 14:51
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice lebrice merged commit 682cce6 into master Oct 11, 2024
9 checks passed
@lebrice lebrice deleted the lebrice/jax-rl-example branch October 11, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants