Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the datamodule config optional #56

Merged
merged 18 commits into from
Oct 2, 2024
Merged

Make the datamodule config optional #56

merged 18 commits into from
Oct 2, 2024

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Oct 1, 2024

No description provided.

lebrice added 3 commits October 1, 2024 14:01
@lebrice
Make the datamodule config optional
ed04bbc 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Remove 'network' field in Config class
f9e77a8 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Revert change to example.yaml config
3ebd87f 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.91837% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.99%. Comparing base (3296b9f) to head (f3b05b5).

Files with missing lines Patch % Lines
project/main.py 62.50% 3 Missing ⚠️
project/configs/config_test.py 96.87% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   70.49%   70.99%   +0.49%     
==========================================
  Files          58       59       +1     
  Lines        3552     3551       -1     
==========================================
+ Hits         2504     2521      +17     
+ Misses       1048     1030      -18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lebrice and others added 14 commits October 1, 2024 14:48
@lebrice
Add test for loading experiment configs
9bd4342 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Remove default algorithm / datamodule
e6fe1ad 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Move configs / add defaults
629c766 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Add the classification metrics cb to ExampleAlgo
e40f55f 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Don't try to print datamodule config
f844d88 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix passing datamodule=None to algorithm
672ed12 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Make algorithm sort-of optional (Hydra required)
e6360b6 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Remove dead code
4ff3d50 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix failing tests in main_test.py
d9a4b39 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Keep algorithm required
229ca3e 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
"fix" test: passing only algorithm isnt enough now
dbcbb1e 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix tests in main_test.py
03119ec 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix issue with main_test.py (again)
a20d9ee 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Update cluster_sweep_example.yaml
2b7184c
@lebrice lebrice marked this pull request as ready for review October 2, 2024 16:09
@lebrice
Remove uncovered branch in ExampleAlgorithm
f3b05b5 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice lebrice force-pushed the lebrice/make-datamodule-optional branch from 709bfe6 to f3b05b5 Compare October 2, 2024 16:14
@lebrice lebrice merged commit 52c88ce into master Oct 2, 2024
7 checks passed
@lebrice lebrice deleted the lebrice/make-datamodule-optional branch October 2, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lebrice @codecov-commenter