Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in the auto_schema script #58

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Oct 3, 2024

Fix various bugs in the auto-schema script:

  • Trailing commas in vscode settings file caused errors.
  • Wouldn't add entries in the vscode settings file if the code executable wasnt found, which is a problem on SLURM clusters where code might not be installed on PATH.

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.99%. Comparing base (52c88ce) to head (ef846c4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
project/utils/auto_schema.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   70.99%   70.99%   -0.01%     
==========================================
  Files          59       59              
  Lines        3551     3554       +3     
==========================================
+ Hits         2521     2523       +2     
- Misses       1030     1031       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lebrice lebrice marked this pull request as ready for review October 3, 2024 19:58
@lebrice lebrice merged commit b76d00d into master Oct 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants