Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify examples, reduce typing verbosity #8

Merged
merged 17 commits into from
Jun 27, 2024
Merged

Simplify examples, reduce typing verbosity #8

merged 17 commits into from
Jun 27, 2024

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Jun 20, 2024 •
edited
Loading

TODOs:

@lebrice lebrice mentioned this pull request Jun 20, 2024
Closed
lebrice added 3 commits June 25, 2024 13:11
@lebrice
Simplify examples by reducing inheritance a bit
3849a65 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix typing errors in samples_per_second.py
df7b8ef 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Simplify some of the algos some more
301c49e 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice lebrice force-pushed the simplify_examples branch from 9a6e218 to 301c49e Compare June 25, 2024 13:11
lebrice added 2 commits June 25, 2024 16:10
@lebrice
Remove ImageClassificationAlgorithm, improve tests
dff590e 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Remove the bases package, ImageClassification
1b429ba 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice lebrice marked this pull request as ready for review June 25, 2024 18:08
lebrice added 5 commits June 25, 2024 18:09
@lebrice
Fix import error
1de4873 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix KeyError in GetMetricCallback
e1ffefb 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Add docstrings in Callback class
4633846 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Tweak to Algorithm.shared_step_end
e1b8b2d 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Fix error in Algorithm.shared_step_end
9018255 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice lebrice self-assigned this Jun 25, 2024
lebrice added 7 commits June 25, 2024 20:58
@lebrice
Slightly simplify some of the test fixtures
314c471 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Update regression files for the datamodules tests
db7d364 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Simplify FcNet config
3addd50 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Add missing MNIST regression files
1ac72dd 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Try to fix the "missing imagenet" error in CI
b056d47 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Add missing NETWORK_DIR in the devcontainer
f9e2374 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Add comment
67b9a83 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice lebrice merged commit 6a42ef0 into master Jun 27, 2024
3 of 4 checks passed
@lebrice lebrice deleted the simplify_examples branch July 2, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lebrice lebrice

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lebrice