Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the example script and rename examples #91

Merged
merged 109 commits into from
Nov 29, 2024
Merged

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Nov 13, 2024

Signed-off-by: Fabrice Normandin normandf@mila.quebec

@lebrice lebrice marked this pull request as ready for review November 14, 2024 20:48
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice lebrice changed the title Simplify the example script a bit Simplify the example script and rename some examples Nov 15, 2024
@lebrice lebrice requested a review from Copilot November 15, 2024 20:10
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 23 out of 32 changed files in this pull request and generated 1 suggestion.

Files not reviewed (9)
  • .regression_files/project/algorithms/example_test/test_initialization_is_reproducible/cuda/fcnet_fashion_mnist_example.yaml: Language not supported
  • project/algorithms/text_classification_example_test.py: Evaluated as low risk
  • docs/examples/index.md: Evaluated as low risk
  • project/algorithms/init.py: Evaluated as low risk
  • project/algorithms/jax_rl_example_test.py: Evaluated as low risk
  • docs/examples/text_classification.md: Evaluated as low risk
  • docs/features/jax.md: Evaluated as low risk
  • project/algorithms/example.py: Evaluated as low risk
  • project/algorithms/llm_finetuning_test.py: Evaluated as low risk
Comments skipped due to low confidence (1)

project/algorithms/text_classification_test.py:39

  • The TODO comment indicates a known issue with a failing test on SLURM. This should be addressed.
# TODO: There's a failing test here only on SLURM?

project/algorithms/example_test.py Outdated Show resolved Hide resolved
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 82.15686% with 91 lines in your changes missing coverage. Please review.

Project coverage is 81.91%. Comparing base (f8e3a22) to head (c569dd2).

Files with missing lines Patch % Lines
project/algorithms/jax_ppo_test.py 55.91% 41 Missing ⚠️
project/utils/testutils.py 73.91% 24 Missing ⚠️
project/datamodules/vision.py 52.94% 8 Missing ⚠️
project/conftest.py 89.47% 4 Missing ⚠️
project/experiment.py 69.23% 4 Missing ⚠️
project/utils/remote_launcher_plugin.py 78.57% 3 Missing ⚠️
...roject/datamodules/image_classification/cifar10.py 60.00% 2 Missing ⚠️
project/utils/autoref_plugin.py 92.30% 2 Missing ⚠️
project/utils/typing_utils/protocols.py 60.00% 2 Missing ⚠️
project/algorithms/jax_image_classifier.py 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   81.22%   81.91%   +0.68%     
==========================================
  Files          63       59       -4     
  Lines        4262     4108     -154     
==========================================
- Hits         3462     3365      -97     
+ Misses        800      743      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lebrice lebrice merged commit f922edf into master Nov 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants