Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary generic Callback class #94

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Dec 2, 2024

Signed-off-by: Fabrice Normandin normandf@mila.quebec

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.78261% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.59%. Comparing base (b40ef22) to head (7245443).

Files with missing lines Patch % Lines
project/algorithms/callbacks/samples_per_second.py 87.09% 4 Missing ⚠️
...ect/algorithms/callbacks/classification_metrics.py 84.61% 2 Missing ⚠️
project/algorithms/jax_ppo_test.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   81.71%   81.59%   -0.13%     
==========================================
  Files          59       58       -1     
  Lines        4064     4026      -38     
==========================================
- Hits         3321     3285      -36     
+ Misses        743      741       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lebrice lebrice marked this pull request as ready for review December 3, 2024 15:11
@lebrice lebrice merged commit 7008e89 into master Dec 3, 2024
8 checks passed
@lebrice lebrice deleted the remove-callback-generic branch December 3, 2024 15:11
lebrice added a commit that referenced this pull request Dec 3, 2024
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants