Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Move source maps to a config setting. #28

Merged
merged 4 commits into from
Feb 16, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Artifact.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ export default abstract class Artifact<T extends object = {}> {

readonly package: Package;

sourceMaps: boolean = false;

state: ArtifactState = 'pending';

constructor(pkg: Package, builds: T[]) {
Expand Down
1 change: 1 addition & 0 deletions src/Package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ export default class Package {
inputs: config.inputs,
namespace: config.namespace,
platform,
sourceMaps: config.sourceMaps,
support: config.support,
});
});
Expand Down
1 change: 1 addition & 0 deletions src/Packemon.ts
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ export default class Packemon {
artifact.namespace = config.namespace;
artifact.platform = config.platform;
artifact.sharedLib = sharedLib;
artifact.sourceMaps = config.sourceMaps;
artifact.support = config.support;

pkg.addArtifact(artifact);
Expand Down
3 changes: 1 addition & 2 deletions src/rollup/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,7 @@ export function getRollupOutputConfig(
sourceMaps: false,
}),
],
// Only enable source maps for browsers
sourcemap: Boolean(features.analyze) || platform !== 'node',
sourcemap: Boolean(features.analyze) || artifact.sourceMaps,
sourcemapExcludeSources: true,
};

Expand Down
1 change: 1 addition & 0 deletions src/schemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ export const packemonBlueprint: Blueprint<PackemonPackageConfig> = {
}),
namespace: string(),
platform: union([array(platform), platform], DEFAULT_PLATFORM),
sourceMaps: bool(),
support,
};

Expand Down
2 changes: 2 additions & 0 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export interface PackemonPackageConfig {
inputs?: Record<string, string>;
namespace?: string;
platform?: Platform | Platform[];
sourceMaps?: boolean;
support?: Support;
}

Expand All @@ -74,6 +75,7 @@ export interface PackageConfig {
inputs: Record<string, string>;
namespace: string;
platform: Platform;
sourceMaps: boolean;
support: Support;
}

Expand Down
44 changes: 44 additions & 0 deletions tests/Package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -755,6 +755,7 @@ describe('Package', () => {
inputs: {},
platform: 'browser',
namespace: '',
sourceMaps: false,
support: 'stable',
},
]);
Expand All @@ -777,6 +778,7 @@ describe('Package', () => {
inputs: {},
platform: 'browser',
namespace: 'test',
sourceMaps: false,
support: 'stable',
},
]);
Expand All @@ -799,6 +801,7 @@ describe('Package', () => {
inputs: {},
platform: 'native',
namespace: '',
sourceMaps: false,
support: 'stable',
},
]);
Expand All @@ -821,6 +824,7 @@ describe('Package', () => {
inputs: {},
platform: 'node',
namespace: '',
sourceMaps: false,
support: 'stable',
},
]);
Expand All @@ -843,6 +847,7 @@ describe('Package', () => {
inputs: {},
platform: 'node',
namespace: '',
sourceMaps: false,
support: 'stable',
},
]);
Expand All @@ -862,13 +867,15 @@ describe('Package', () => {
inputs: {},
platform: 'browser',
namespace: '',
sourceMaps: false,
support: 'stable',
},
{
formats: ['lib'],
inputs: {},
platform: 'node',
namespace: '',
sourceMaps: false,
support: 'stable',
},
]);
Expand All @@ -889,20 +896,57 @@ describe('Package', () => {
inputs: {},
platform: 'browser',
namespace: '',
sourceMaps: false,
support: 'stable',
},
{
formats: ['lib', 'cjs'],
inputs: {},
platform: 'node',
namespace: '',
sourceMaps: false,
support: 'stable',
},
{
formats: ['lib'],
inputs: {},
platform: 'native',
namespace: '',
sourceMaps: false,
support: 'stable',
},
]);
});

it('can set separate source maps', () => {
pkg.setConfigs([
{
inputs: {},
platform: 'browser',
sourceMaps: true,
},
{
inputs: {},
platform: 'node',
sourceMaps: false,
},
]);

expect(pkg.configs).toEqual([
{
formats: ['lib', 'esm'],
inputs: {},
platform: 'browser',
namespace: '',
sourceMaps: true,
support: 'stable',
},
{
formats: ['lib'],
inputs: {},
platform: 'node',
namespace: '',
sourceMaps: false,
support: 'stable',
},
]);
Expand Down
4 changes: 4 additions & 0 deletions tests/Packemon.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -467,13 +467,15 @@ describe('Packemon', () => {
inputs: { index: 'src/index.ts' },
namespace: '',
platform: 'node',
sourceMaps: false,
support: 'stable',
},
{
formats: ['lib', 'esm'],
inputs: { index: 'src/index.ts' },
namespace: '',
platform: 'browser',
sourceMaps: false,
support: 'current',
},
]);
Expand All @@ -485,6 +487,7 @@ describe('Packemon', () => {
inputs: { core: './src/core.ts' },
namespace: '',
platform: 'node',
sourceMaps: false,
support: 'stable',
},
]);
Expand All @@ -496,6 +499,7 @@ describe('Packemon', () => {
inputs: { index: 'src/index.ts' },
namespace: 'Test',
platform: 'browser',
sourceMaps: false,
support: 'stable',
},
]);
Expand Down
1 change: 1 addition & 0 deletions tests/__fixtures__/examples/source-maps.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
function foo() {}
Loading