Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization #214

Merged
merged 4 commits into from
Aug 28, 2022
Merged

Localization #214

merged 4 commits into from
Aug 28, 2022

Conversation

christianwgd
Copy link
Contributor

Added general localization ability and a german locale

Open: Localization should be documented in the guides.

  - Add gettext to literals
  - Add trans template tag to templates
  - Set localized date and time
  - Add locale option to TEMPLATE.env
  - Add migrations that result from model field changes
Copy link
Owner

@milesmcc milesmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting in the time to make these changes. I'm eager to merge them. Just see my two notes about migrations — are these necessary?

@milesmcc milesmcc merged commit d134c00 into milesmcc:master Aug 28, 2022
@milesmcc
Copy link
Owner

Thank you @christianwgd!

@danya02
Copy link

danya02 commented Sep 13, 2022

It seems that on some templates you may have forgotten a "load i18n" directive, which makes rendering these pages fail. I've detected this problem on dashboard/pages/service_delete.html and dashboard/pages/service_session.html, because opening /dashboard/service/<...>/sessions/<...> and /dashboard/service/<...>/delete shows a big "Server Error (500)" page.

@christianwgd
Copy link
Contributor Author

Sorry for that. I've checked and added the missing "i18n" tags with a new pull request.

@milesmcc
Copy link
Owner

PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants