Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove oracle v1, v2 contracts #124

Merged
merged 4 commits into from
May 1, 2024
Merged

Conversation

rustcandy
Copy link
Contributor

Overview

Removed the code related to oracle V1, V2 contracts. It won't update them after this migration.

closes: #XXXX

What changes have been made in this PR?

  • [ ]

Checklist


  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration
  • Updated relevant documentation

Copy link
Contributor

coderabbitai bot commented May 1, 2024

Walkthrough

The recent updates focus on streamlining the handling of oracle rates in a Rust-based staking contract. The changes involve consolidating rate update logic, removing outdated rate handling structures, and simplifying response structures across modules. These modifications aim to enhance code clarity, maintainability, and test alignment with the revised functionality.

Changes

File(s) Summary
Cargo.toml Updated version from "0.4.17" to "0.4.18".
contracts/staking/src/execute.rs, contracts/staking/src/oracle.rs Unified rate update logic, removed outdated rate handling structures.
contracts/staking/src/msg.rs Simplified ConfigResponse by removing multiple oracle addresses.
contracts/staking/src/tests/... Adjusted tests to reflect updated message handling and reduced complexity for improved clarity.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 513377d and 1abfb5c.
Files selected for processing (2)
  • contracts/staking/src/execute.rs (2 hunks)
  • contracts/staking/src/oracle.rs (1 hunks)
Files skipped from review as they are similar to previous changes (2)
  • contracts/staking/src/execute.rs
  • contracts/staking/src/oracle.rs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@manu0466 manu0466 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.
Can you please remove the unused imports in the execute.rs and oracle.rs files?

@rustcandy rustcandy requested a review from manu0466 May 1, 2024 15:06
@RiccardoM RiccardoM merged commit b0cc7ba into main May 1, 2024
1 check passed
@RiccardoM RiccardoM deleted the rustcandy/remove_oracle branch May 1, 2024 15:44
Copy link
Contributor

@hallazzang hallazzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants