noop support for ArrowFunctionExpression

millermedeiros · Jun 2, 2017 · ef52228 · ef52228
1 parent 72e4d95
commit ef52228
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/lib/hooks/ArrowFunctionExpression.js b/lib/hooks/ArrowFunctionExpression.js
@@ -42,7 +42,15 @@ function shouldHandleParams(node) {
 }
 
 function shouldIndentBody(node, opts) {
-  // we don't want to indent the body twice if ObjectExpression or
-  // ArrayExpression or CallExpression
-  return node.body.type === 'BlockStatement' || !opts[node.body.type];
+  var bodyFirstNonEmpty = tk.findNextNonEmpty(node.body.startToken);
+
+  if (bodyFirstNonEmpty.value === '}') {
+    // noop
+    limit.after(node.body.startToken, 0);
+    return false;
+  } else {
+    // we don't want to indent the body twice if ObjectExpression or
+    // ArrayExpression or CallExpression
+    return node.body.type === 'BlockStatement' || !opts[node.body.type];
+  }
 }
diff --git a/test/compare/default/arrow_function_expression-in.js b/test/compare/default/arrow_function_expression-in.js
@@ -7,6 +7,13 @@ arr.map(d    =>
         {return d * 2;});
         arr.map(   ( e , f     , g)  => e * f - g );
 
+// noop (#487)
+const f1 = () => {};
+const f2  =  (  )  =>  {    };
+const f3  =  (  )  =>  {
+
+};
+
 // default params (#285)
 let defaultParams = (x, y   =   1, z  =  2  ) => {
   return x + y + z;

diff --git a/test/compare/default/arrow_function_expression-out.js b/test/compare/default/arrow_function_expression-out.js
@@ -10,6 +10,11 @@ arr.map(d => {
 });
 arr.map((e, f, g) => e * f - g);
 
+// noop (#487)
+const f1 = () => {};
+const f2 = () => {};
+const f3 = () => {};
+
 // default params (#285)
 let defaultParams = (x, y = 1, z = 2) => {
   return x + y + z;