Use conan to manage depedency #728
Conversation
conanfile.py
Outdated
| self.requires("nlohmann_json/3.11.2") | ||
| self.requires("llvm-openmp/12.0.1") | ||
| if self.options.with_ut: | ||
| self.requires("gtest/1.8.1") |
There was a problem hiding this comment.
seems previous we use gtest 1.12, AIK gtest<=1.10 may have some compilation problems for the new compiler.
|
A general discussion about how to use knowhere from the developer's view, recently I'm thinking of this for As knowhere is a library, it's not fully like milvus, so developers may use knowhere as a component and integrate it into their own project, for milvus currently most developers will only use the final binary. Just like grpc, when I go through grpc-cpp's README it tells me grpc could be imported by Bazal, Cmake, vcpkg and also conan(which not documented in README) |
| ) | ||
| FetchContent_MakeAvailable(nlohmann_json) | ||
| endif() | ||
| set(CMAKE_CXX_STANDARD 17) |
There was a problem hiding this comment.
no need set CMAKE_CXX_STANARD again.
| if(WITH_RAFT) | ||
| include(cmake/libs/libraft.cmake) | ||
| endif() | ||
|
|
||
| find_package(nlohmann_json) |
There was a problem hiding this comment.
split this into cmake/lib as a nlohmann_json.cmake maybe looks better.
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiaoew1991, liliu-z The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #727