Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

Add test_bruteforce to improve code coverage #958

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Add test_bruteforce to improve code coverage #958

merged 1 commit into from
Jun 27, 2023

Conversation

cydrain
Copy link
Collaborator

@cydrain cydrain commented Jun 26, 2023 •
edited
Loading

Issue: #960

Before:

Overall coverage rate:
  lines......: 70.7% (1871 of 2646 lines)
  functions..: 52.7% (330 of 626 functions)

After:

Overall coverage rate:
  lines......: 74.1% (1966 of 2652 lines)
  functions..: 53.4% (335 of 627 functions)

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link

mergify bot commented Jun 26, 2023

@cydrain Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@cydrain cydrain force-pushed the caiyd_add_bf_test_for_codecov branch 3 times, most recently from 11ea6a9 to 6ff749c Compare June 26, 2023 09:40
@cydrain
Add test_bruteforce to improve code coverage
8b9a6af 
Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
@cydrain cydrain force-pushed the caiyd_add_bf_test_for_codecov branch from 6ff749c to 8b9a6af Compare June 26, 2023 10:51
@cydrain
Copy link
Collaborator Author

cydrain commented Jun 26, 2023

/kind improvement

@zhengbuqian
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit 0acfc4a into milvus-io:main Jun 27, 2023
@cydrain cydrain deleted the caiyd_add_bf_test_for_codecov branch June 27, 2023 03:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liliu-z liliu-z Awaiting requested review from liliu-z

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

Assignees

@zhengbuqian zhengbuqian

Labels
approved ci-passed dco-passed DCO check passed. kind/improvement lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cydrain @sre-ci-robot @zhengbuqian