Not passing index type when not set

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
milvus-io · Apr 8, 2024 · 270cde5 · 270cde5
1 parent 649a6db
commit 270cde5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/entity/index_scalar.go b/entity/index_scalar.go
@@ -7,9 +7,11 @@ type indexScalar struct {
 }
 
 func (i *indexScalar) Params() map[string]string {
-	return map[string]string{
-		tIndexType: string(i.baseIndex.it),
+	result := make(map[string]string)
+	if i.baseIndex.it != "" {
+		result[tIndexType] = string(i.baseIndex.it)
 	}
+	return result
 }
 
 func NewScalarIndex() Index {

diff --git a/entity/index_scalar_test.go b/entity/index_scalar_test.go
@@ -10,6 +10,8 @@ func TestScalarIndex(t *testing.T) {
 	oldScalarIdx := NewScalarIndex()
 
 	assert.EqualValues(t, "", oldScalarIdx.IndexType(), "use AUTO index when index type not provided")
+	_, has := oldScalarIdx.Params()[tIndexType]
+	assert.False(t, has)
 
 	idxWithType := NewScalarIndexWithType(Sorted)