fix: deduce AutoID from field info

Resolves: #654 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
milvus-io · Jan 30, 2024 · 890de2b · 890de2b
1 parent 7049e72
commit 890de2b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/entity/schema.go b/entity/schema.go
@@ -107,11 +107,13 @@ func (s *Schema) ProtoMessage() *schema.CollectionSchema {
 
 // ReadProto parses proto Collection Schema
 func (s *Schema) ReadProto(p *schema.CollectionSchema) *Schema {
-	s.AutoID = p.GetAutoID()
 	s.Description = p.GetDescription()
 	s.CollectionName = p.GetName()
 	s.Fields = make([]*Field, 0, len(p.GetFields()))
 	for _, fp := range p.GetFields() {
+		if fp.GetAutoID() {
+			s.AutoID = true
+		}
 		s.Fields = append(s.Fields, NewField().ReadProto(fp))
 	}
 	s.EnableDynamicField = p.GetEnableDynamicField()

diff --git a/entity/schema_test.go b/entity/schema_test.go
@@ -107,7 +107,6 @@ func (s *SchemaSuite) TestBasic() {
 			nsch = nsch.ReadProto(p)
 
 			s.Equal(sch.CollectionName, nsch.CollectionName)
-			s.Equal(sch.AutoID, nsch.AutoID)
 			s.Equal(sch.Description, nsch.Description)
 			s.Equal(sch.EnableDynamicField, nsch.EnableDynamicField)
 			s.Equal(len(sch.Fields), len(nsch.Fields))