Skip to content

Commit

Permalink
Remove default partition name logic from InsertRows and Upsert (#587
Browse files Browse the repository at this point in the history
)

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
  • Loading branch information
congqixia committed Sep 21, 2023
1 parent 2ba985a commit bc0a305
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
4 changes: 1 addition & 3 deletions client/insert.go
Original file line number Diff line number Diff line change
Expand Up @@ -410,9 +410,7 @@ func (c *GrpcClient) Upsert(ctx context.Context, collName string, partitionName
CollectionName: collName,
PartitionName: partitionName,
}
if req.PartitionName == "" {
req.PartitionName = "_default" // use default partition
}

req.NumRows = uint32(rowSize)
for _, column := range columns {
req.FieldsData = append(req.FieldsData, column.FieldData())
Expand Down
5 changes: 1 addition & 4 deletions client/row.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,7 @@ func (c *GrpcClient) InsertRows(ctx context.Context, collName string, partitionN
CollectionName: collName,
PartitionName: partitionName,
}
//c.Service.
if req.PartitionName == "" {
req.PartitionName = "_default" // use default partition
}

req.NumRows = uint32(len(rows))
for _, column := range columns {
req.FieldsData = append(req.FieldsData, column.FieldData())
Expand Down

0 comments on commit bc0a305

Please sign in to comment.