Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Search result set may return false error when result set is empty #623

Closed
1 task done
congqixia opened this issue Nov 9, 2023 · 1 comment
Closed
1 task done
Assignees

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Search result set will has error with "unsupported data type None of field" when resultset is empty

Expected Behavior

Resultset shall not have error when response result count is 0

Steps To Reproduce

No response

Environment

No response

Anything else?

No response

@congqixia congqixia self-assigned this Nov 9, 2023
congqixia added a commit to congqixia/milvus-sdk-go that referenced this issue Nov 9, 2023
Since empty field data has no info for fieldName nor field type
it's more meaningful to skip parse field data for empty resultSet

This PR adds ResultCount check before performing fieldData parsing
When resultSet is empty, the entry shall have no error with empty fields
See also milvus-io#623

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Nov 10, 2023
Since empty field data has no info for fieldName nor field type
it's more meaningful to skip parse field data for empty resultSet

This PR adds ResultCount check before performing fieldData parsing
When resultSet is empty, the entry shall have no error with empty fields
See also #623

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia
Copy link
Contributor Author

Close as done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant