Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mock server suite base #412

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

congqixia
Copy link
Contributor

See also #410 #411

/kind improvement

Signed-off-by: Congqi Xia congqi.xia@zilliz.com

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Mar 3, 2023
@sre-ci-robot sre-ci-robot requested a review from sunby March 3, 2023 08:08
@sre-ci-robot sre-ci-robot added approved review approved size/XL Denotes a PR that changes 500-999 lines. labels Mar 3, 2023
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #412 (df2666b) into master (f5d28d7) will increase coverage by 3.57%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   83.40%   86.98%   +3.57%     
==========================================
  Files          30       29       -1     
  Lines        3049     2735     -314     
==========================================
- Hits         2543     2379     -164     
+ Misses        413      269     -144     
+ Partials       93       87       -6     
Impacted Files Coverage Δ
client/client_grpc_collection.go 85.99% <ø> (ø)
client/client_grpc_data.go 72.32% <ø> (ø)
client/client_grpc_options.go 78.26% <ø> (ø)
client/client_grpc_partition.go 82.67% <ø> (ø)
client/client_grpc_row.go 83.48% <ø> (ø)
client/errors.go 50.00% <ø> (ø)
client/client_mock_test.go

@mergify mergify bot added the ci-passed auto merge needed label label Mar 3, 2023
Copy link
Contributor

@jiaoew1991 jiaoew1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Mar 6, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jiaoew1991

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit fa5ada2 into milvus-io:master Mar 6, 2023
@congqixia congqixia deleted the add_mock_server branch June 13, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants