Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource Group API #417

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

congqixia
Copy link
Contributor

See also #415

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Mar 7, 2023
@sre-ci-robot sre-ci-robot requested a review from sunby March 7, 2023 11:56
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/XXL Denotes a PR that changes 1000+ lines. labels Mar 7, 2023
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #417 (49e47d5) into master (69f7d14) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
+ Coverage   87.15%   87.44%   +0.29%     
==========================================
  Files          29       30       +1     
  Lines        2740     2804      +64     
==========================================
+ Hits         2388     2452      +64     
  Misses        267      267              
  Partials       85       85              
Impacted Files Coverage Δ
client/client.go 75.80% <ø> (ø)
client/client_grpc_rg.go 100.00% <100.00%> (ø)

@mergify mergify bot added the ci-passed auto merge needed label label Mar 7, 2023
Copy link
Contributor

@weiliu1031 weiliu1031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Mar 8, 2023
@sre-ci-robot sre-ci-robot merged commit 01b5dd8 into milvus-io:master Mar 8, 2023
@congqixia congqixia deleted the add_rg_api branch June 13, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants