Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlterCollection API #435

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

congqixia
Copy link
Contributor

See also #433
/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Apr 21, 2023
@sre-ci-robot sre-ci-robot requested a review from sunby April 21, 2023 03:19
@sre-ci-robot sre-ci-robot added approved review approved size/XL Denotes a PR that changes 500-999 lines. labels Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #435 (c7884c0) into master (ab01955) will increase coverage by 0.08%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   87.27%   87.35%   +0.08%     
==========================================
  Files          30       31       +1     
  Lines        2844     2878      +34     
==========================================
+ Hits         2482     2514      +32     
- Misses        273      274       +1     
- Partials       89       90       +1     
Impacted Files Coverage Δ
client/client.go 75.80% <ø> (ø)
client/collection.go 88.31% <91.30%> (ø)
entity/collection_attr.go 100.00% <100.00%> (ø)

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@mergify mergify bot added the ci-passed auto merge needed label label Apr 21, 2023
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Apr 21, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 40fea39 into milvus-io:master Apr 21, 2023
@congqixia congqixia deleted the add_alter_collection branch June 13, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants