Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang.org/x/net version manually #437

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

congqixia
Copy link
Contributor

/kind improvement
Fix #413

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Apr 21, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested a review from sunby April 21, 2023 10:41
@sre-ci-robot sre-ci-robot added the approved review approved label Apr 21, 2023
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 21, 2023
@congqixia congqixia force-pushed the bump_x_net branch 2 times, most recently from fbbe448 to 1a753a0 Compare August 11, 2023 11:14
@congqixia congqixia force-pushed the bump_x_net branch 4 times, most recently from dfdd1c8 to 87b83cd Compare August 22, 2023 10:39
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #437 (7a79131) into master (99befb5) will increase coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
+ Coverage   82.92%   82.96%   +0.04%     
==========================================
  Files          40       40              
  Lines        3654     3652       -2     
==========================================
  Hits         3030     3030              
+ Misses        510      508       -2     
  Partials      114      114              
Files Changed Coverage Δ
client/data.go 69.23% <ø> (ø)
client/maintainance.go 95.34% <ø> (ø)
client/options.go 60.27% <ø> (ø)
client/row.go 85.65% <ø> (+0.76%) ⬆️

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@mergify mergify bot added the ci-passed auto merge needed label label Aug 22, 2023
@yah01
Copy link
Member

yah01 commented Aug 22, 2023

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Aug 22, 2023
@sre-ci-robot sre-ci-robot merged commit 6532a69 into milvus-io:master Aug 22, 2023
6 checks passed
@congqixia congqixia deleted the bump_x_net branch August 28, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: dependency security alert for golang/x/net
3 participants