Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON data type #443

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Conversation

congqixia
Copy link
Contributor

See also #432
Related to milvus-io/milvus#23389
/kind enhancement

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Apr 24, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested a review from sunby April 24, 2023 07:44
@sre-ci-robot sre-ci-robot added approved review approved size/L Denotes a PR that changes 100-499 lines. labels Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #443 (5665f9f) into master (e6dc380) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   87.35%   87.48%   +0.13%     
==========================================
  Files          31       32       +1     
  Lines        2878     2909      +31     
==========================================
+ Hits         2514     2545      +31     
  Misses        274      274              
  Partials       90       90              
Impacted Files Coverage Δ
entity/columns_json.go 100.00% <100.00%> (ø)
entity/schema.go 93.44% <100.00%> (+0.33%) ⬆️

@mergify mergify bot added the ci-passed auto merge needed label label Apr 24, 2023
@yah01
Copy link
Member

yah01 commented Apr 24, 2023

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Apr 24, 2023
@sre-ci-robot sre-ci-robot merged commit e8056f9 into milvus-io:master Apr 24, 2023
@congqixia congqixia deleted the add_json_datatype branch June 13, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants