Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vector field type check logic #447

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

congqixia
Copy link
Contributor

Related to #445
/kind bug

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/bug Something isn't working label Apr 26, 2023
@sre-ci-robot sre-ci-robot requested a review from sunby April 26, 2023 10:42
@sre-ci-robot sre-ci-robot added approved review approved size/S Denotes a PR that changes 10-29 lines. labels Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #447 (a0ca2a6) into master (ab87966) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
- Coverage   87.27%   87.22%   -0.06%     
==========================================
  Files          32       32              
  Lines        2916     2920       +4     
==========================================
+ Hits         2545     2547       +2     
- Misses        281      282       +1     
- Partials       90       91       +1     
Impacted Files Coverage Δ
entity/columns.go 88.80% <100.00%> (-1.20%) ⬇️

@mergify mergify bot added the ci-passed auto merge needed label label Apr 26, 2023
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Apr 26, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 52df79f into milvus-io:master Apr 26, 2023
@congqixia congqixia deleted the query_emptyresultr branch June 13, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/bug Something isn't working lgtm look good to me size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants