Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle LongData returned when queryresult is empty #450

Merged

Conversation

congqixia
Copy link
Contributor

See also milvus-io/milvus#23850
/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label May 4, 2023
@sre-ci-robot sre-ci-robot requested a review from sunby May 4, 2023 07:52
@sre-ci-robot sre-ci-robot added approved review approved size/S Denotes a PR that changes 10-29 lines. labels May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #450 (c6d22de) into v2.2.x (0f8c85b) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v2.2.x     #450      +/-   ##
==========================================
+ Coverage   87.45%   87.50%   +0.04%     
==========================================
  Files          31       31              
  Lines        2837     2848      +11     
==========================================
+ Hits         2481     2492      +11     
  Misses        269      269              
  Partials       87       87              
Impacted Files Coverage Δ
entity/columns.go 95.58% <100.00%> (+0.38%) ⬆️

@congqixia congqixia force-pushed the handle_longdata_emptyquery branch from d8ad975 to 48ea2e2 Compare May 4, 2023 07:58
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia force-pushed the handle_longdata_emptyquery branch from 48ea2e2 to c6d22de Compare May 4, 2023 08:09
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels May 4, 2023
@mergify mergify bot added the ci-passed auto merge needed label label May 4, 2023
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the lgtm look good to me label May 4, 2023
@sre-ci-robot sre-ci-robot merged commit ea26083 into milvus-io:v2.2.x May 4, 2023
congqixia added a commit to congqixia/milvus-sdk-go that referenced this pull request May 4, 2023
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request May 5, 2023
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia deleted the handle_longdata_emptyquery branch May 26, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants