Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AutoCompactionEnabled collection attribute #452

Merged
merged 1 commit into from
May 12, 2023

Conversation

congqixia
Copy link
Contributor

Related to milvus-io/milvus#23993
/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label May 11, 2023
@sre-ci-robot sre-ci-robot requested a review from sunby May 11, 2023 02:14
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/M Denotes a PR that changes 30-99 lines. labels May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #452 (50b3f8f) into master (73c54d3) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
+ Coverage   87.27%   87.30%   +0.03%     
==========================================
  Files          32       32              
  Lines        2931     2939       +8     
==========================================
+ Hits         2558     2566       +8     
  Misses        282      282              
  Partials       91       91              
Impacted Files Coverage Δ
entity/collection_attr.go 100.00% <100.00%> (ø)

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@mergify mergify bot added the ci-passed auto merge needed label label May 12, 2023
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label May 12, 2023
@sre-ci-robot sre-ci-robot merged commit b302dfd into milvus-io:master May 12, 2023
@congqixia congqixia deleted the add_ca_autocompaction branch May 22, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants