Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt dynamic field and support insert column when dynamic field enabled #455

Merged

Conversation

congqixia
Copy link
Contributor

See also milvus-io/milvus#24232
/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label May 18, 2023
@sre-ci-robot sre-ci-robot requested a review from sunby May 18, 2023 15:55
@sre-ci-robot sre-ci-robot added approved review approved size/XXL Denotes a PR that changes 1000+ lines. labels May 18, 2023
@congqixia congqixia force-pushed the support_dynamic_schema_insert_column branch from 10fcedd to 6732da7 Compare May 18, 2023 16:07
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #455 (ccd5978) into master (a03eb3e) will decrease coverage by 1.11%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
- Coverage   87.30%   86.19%   -1.11%     
==========================================
  Files          32       33       +1     
  Lines        2939     3065     +126     
==========================================
+ Hits         2566     2642      +76     
- Misses        282      331      +49     
- Partials       91       92       +1     
Impacted Files Coverage Δ
client/data.go 70.64% <ø> (ø)
client/row.go 83.48% <ø> (ø)
entity/columns.go 88.43% <0.00%> (-1.22%) ⬇️
entity/columns_json.go 89.28% <0.00%> (-10.72%) ⬇️
entity/columns_scalar_gen.go 87.50% <0.00%> (-12.50%) ⬇️
entity/columns_varchar.go 90.32% <0.00%> (-9.68%) ⬇️
entity/columns_vector_gen.go 89.65% <0.00%> (-10.35%) ⬇️
client/insert.go 79.86% <79.86%> (ø)
entity/schema.go 93.58% <94.59%> (+0.14%) ⬆️

@congqixia congqixia force-pushed the support_dynamic_schema_insert_column branch 2 times, most recently from 4675f4c to 9e05976 Compare May 19, 2023 04:30
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia force-pushed the support_dynamic_schema_insert_column branch from 9e05976 to ccd5978 Compare May 19, 2023 04:40
@mergify mergify bot added the ci-passed auto merge needed label label May 19, 2023
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label May 19, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c8aa151 into milvus-io:master May 19, 2023
@congqixia congqixia deleted the support_dynamic_schema_insert_column branch May 22, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants