Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file naming and schema creation usage #458

Merged

Conversation

congqixia
Copy link
Contributor

/kind improvement

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label May 22, 2023
@sre-ci-robot sre-ci-robot requested a review from sunby May 22, 2023 04:15
@sre-ci-robot sre-ci-robot added approved review approved size/L Denotes a PR that changes 100-499 lines. labels May 22, 2023
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #458 (e49dcc2) into master (b619b53) will decrease coverage by 0.05%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
- Coverage   85.14%   85.10%   -0.05%     
==========================================
  Files          34       35       +1     
  Lines        3232     3236       +4     
==========================================
+ Hits         2752     2754       +2     
+ Misses        382      381       -1     
- Partials       98      101       +3     
Impacted Files Coverage Δ
client/admin.go 83.33% <ø> (ø)
client/alias.go 100.00% <ø> (ø)
client/authentication.go 100.00% <ø> (ø)
client/index.go 77.95% <ø> (ø)
client/maintainance.go 95.55% <ø> (ø)
client/options.go 66.66% <ø> (ø)
client/partition.go 84.25% <ø> (ø)
client/rbac.go 100.00% <ø> (ø)
client/resource_group.go 100.00% <ø> (ø)
entity/schema.go 94.18% <50.00%> (+0.13%) ⬆️
... and 2 more

@mergify mergify bot added the ci-passed auto merge needed label label May 22, 2023
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label May 22, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f6daf36 into milvus-io:master May 22, 2023
@congqixia congqixia deleted the improve_naming_schema_create branch May 22, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants