Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSON datatype #461

Merged
merged 1 commit into from
May 23, 2023
Merged

Support JSON datatype #461

merged 1 commit into from
May 23, 2023

Conversation

congqixia
Copy link
Contributor

See also #432
Related to milvus-io/milvus#23389
/kind enhancement

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label May 23, 2023
@sre-ci-robot sre-ci-robot requested a review from sunby May 23, 2023 04:12
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/XXL Denotes a PR that changes 1000+ lines. labels May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #461 (0cff0a4) into v2.2.x (8b02b8e) will increase coverage by 0.05%.
The diff coverage is 91.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v2.2.x     #461      +/-   ##
==========================================
+ Coverage   86.69%   86.74%   +0.05%     
==========================================
  Files          33       34       +1     
  Lines        2932     2966      +34     
==========================================
+ Hits         2542     2573      +31     
- Misses        300      303       +3     
  Partials       90       90              
Impacted Files Coverage Δ
client/admin.go 83.33% <ø> (ø)
client/alias.go 100.00% <ø> (ø)
client/authentication.go 100.00% <ø> (ø)
client/collection.go 85.40% <ø> (ø)
client/data.go 72.72% <ø> (ø)
client/database.go 92.85% <ø> (ø)
client/index.go 77.95% <ø> (ø)
client/maintainance.go 95.55% <ø> (ø)
client/options.go 79.16% <ø> (ø)
client/partition.go 82.67% <ø> (ø)
... and 5 more

@mergify mergify bot added the ci-passed auto merge needed label label May 23, 2023
@yah01
Copy link
Member

yah01 commented May 23, 2023

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label May 23, 2023
@sre-ci-robot sre-ci-robot merged commit a283bb5 into milvus-io:v2.2.x May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants