Support anonymous dynamic schema #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sre-ci-robot
added
approved
congqixia
force-pushed
the
anonymous_dynamic_schema
branch
from
6ec7459
to
7b16e45
Compare
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
force-pushed
the
anonymous_dynamic_schema
branch
from
7b16e45
to
d5e2f61
Compare
Codecov Report
@@ Coverage Diff @@
## master #462 +/- ##
==========================================
- Coverage 85.00% 84.85% -0.15%
==========================================
Files 35 35
Lines 3280 3269 -11
==========================================
- Hits 2788 2774 -14
- Misses 389 393 +4
+ Partials 103 102 -1
|
yah01
suggested changes
May 24, 2023
| @@ -92,12 +92,12 @@ func (c *GrpcClient) Search(ctx context.Context, collName string, partitions []s | |||
| } | |||
|
|
|||
| func (c *GrpcClient) parseSearchResult(sch *entity.Schema, outputFields []string, fieldDataList []*schema.FieldData, idx, from, to int) ([]entity.Column, error) { | |||
| dynamicField := sch.GetDynamicField() | |||
| //dynamicField := sch.GetDynamicField() | |||
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also milvus-io/milvus#24232
/kind enhancement