Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support row interface with map[string]any #466

Merged
merged 1 commit into from
May 25, 2023

Conversation

congqixia
Copy link
Contributor

See also milvus-io/milvus#24232
/kind enhancement

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label May 25, 2023
@sre-ci-robot sre-ci-robot requested a review from sunby May 25, 2023 07:17
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/L Denotes a PR that changes 100-499 lines. labels May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #466 (88e9fe1) into master (6368d50) will decrease coverage by 0.09%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
- Coverage   84.85%   84.77%   -0.09%     
==========================================
  Files          35       35              
  Lines        3269     3283      +14     
==========================================
+ Hits         2774     2783       +9     
- Misses        393      397       +4     
- Partials      102      103       +1     
Impacted Files Coverage Δ
entity/rows.go 86.77% <78.57%> (-1.39%) ⬇️

@mergify mergify bot added the ci-passed auto merge needed label label May 25, 2023
@yah01
Copy link
Member

yah01 commented May 25, 2023

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label May 25, 2023
@sre-ci-robot sre-ci-robot merged commit 096d105 into milvus-io:master May 25, 2023
@congqixia congqixia deleted the dyn_sch_map branch June 13, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants