Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logical partition num options for create collection #467

Merged
merged 1 commit into from
May 25, 2023

Conversation

congqixia
Copy link
Contributor

See also milvus-io/milvus#24402
/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label May 25, 2023
@sre-ci-robot sre-ci-robot requested a review from sunby May 25, 2023 07:44
@sre-ci-robot sre-ci-robot added approved review approved size/S Denotes a PR that changes 10-29 lines. labels May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #467 (92ed1cf) into master (096d105) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
+ Coverage   84.77%   84.78%   +0.01%     
==========================================
  Files          35       35              
  Lines        3283     3286       +3     
==========================================
+ Hits         2783     2786       +3     
  Misses        397      397              
  Partials      103      103              
Impacted Files Coverage Δ
client/collection.go 87.81% <100.00%> (+0.04%) ⬆️
client/options.go 68.00% <100.00%> (+1.33%) ⬆️

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@mergify mergify bot added the ci-passed auto merge needed label label May 25, 2023
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label May 25, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 104724a into milvus-io:master May 25, 2023
@congqixia congqixia deleted the logical_partition_num_opt branch June 13, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants