Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scalar index #498

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

congqixia
Copy link
Contributor

For Scalar index support:

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jun 25, 2023
@sre-ci-robot sre-ci-robot requested a review from sunby June 25, 2023 03:26
@sre-ci-robot sre-ci-robot added approved review approved size/L Denotes a PR that changes 100-499 lines. labels Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #498 (eb5427c) into v2.2.x (f399a77) will decrease coverage by 0.20%.
The diff coverage is 13.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v2.2.x     #498      +/-   ##
==========================================
- Coverage   80.65%   80.46%   -0.20%     
==========================================
  Files          34       35       +1     
  Lines        2812     2820       +8     
==========================================
+ Hits         2268     2269       +1     
- Misses        432      438       +6     
- Partials      112      113       +1     
Impacted Files Coverage Δ
client/grpc_client.go 47.50% <0.00%> (ø)
entity/index.go 100.00% <ø> (ø)
entity/index_scalar.go 0.00% <0.00%> (ø)
client/index.go 76.92% <20.00%> (-1.03%) ⬇️
client/data.go 68.85% <50.00%> (ø)

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@mergify mergify bot added the ci-passed auto merge needed label label Jun 25, 2023
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jun 26, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7589432 into milvus-io:v2.2.x Jun 26, 2023
@congqixia congqixia deleted the support_scalar_index branch July 21, 2023 02:59
congqixia added a commit to congqixia/milvus-sdk-go that referenced this pull request Aug 11, 2023
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Aug 11, 2023
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants