Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl check health #525

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

huanghaoyuanhhy
Copy link
Contributor

close #523

@sre-ci-robot
Copy link

Welcome @huanghaoyuanhhy! It looks like this is your first PR to milvus-io/milvus-sdk-go 🎉

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #525 (869ef9f) into master (8a5f679) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
+ Coverage   82.93%   82.98%   +0.05%     
==========================================
  Files          40       40              
  Lines        3656     3668      +12     
==========================================
+ Hits         3032     3044      +12     
  Misses        512      512              
  Partials      112      112              
Files Coverage Δ
client/admin.go 94.44% <100.00%> (+11.11%) ⬆️
client/client.go 28.94% <ø> (ø)

Signed-off-by: huanghaoyuan <haoyuan.huang@zilliz.com>
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/kind enhancement

@sre-ci-robot sre-ci-robot added kind/enhancement New feature or request lgtm look good to me labels Oct 25, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, huanghaoyuanhhy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Oct 25, 2023
@congqixia
Copy link
Contributor

@huanghaoyuanhhy nice work!

@sre-ci-robot sre-ci-robot merged commit be61c85 into milvus-io:master Oct 25, 2023
7 checks passed
ThreadDao pushed a commit to ThreadDao/milvus-sdk-go that referenced this pull request Nov 6, 2023
Signed-off-by: huanghaoyuan <haoyuan.huang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: support checkhealth
3 participants