Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove time travel #549

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

jiaoew1991
Copy link
Contributor

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Aug 7, 2023
client/options.go Outdated Show resolved Hide resolved
@jiaoew1991 jiaoew1991 force-pushed the remove-time-travel branch 2 times, most recently from 865b744 to 0fa0de7 Compare August 7, 2023 08:57
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #549 (0fa0de7) into master (1536418) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #549   +/-   ##
=======================================
  Coverage   82.59%   82.60%           
=======================================
  Files          39       39           
  Lines        3540     3535    -5     
=======================================
- Hits         2924     2920    -4     
+ Misses        504      503    -1     
  Partials      112      112           
Files Changed Coverage Δ
client/data.go 69.23% <ø> (-0.18%) ⬇️
client/maintainance.go 95.34% <ø> (-0.21%) ⬇️
client/options.go 60.27% <0.00%> (+0.81%) ⬆️

@mergify mergify bot added the ci-passed auto merge needed label label Aug 7, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Aug 7, 2023
@sre-ci-robot sre-ci-robot added the lgtm look good to me label Aug 7, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jiaoew1991

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Aug 7, 2023
@sre-ci-robot sre-ci-robot merged commit 16b9b53 into milvus-io:master Aug 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants