Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the field name check of the drop index api #554

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Aug 14, 2023

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Aug 14, 2023
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #554 (a9fc1d8) into master (c059057) will increase coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
+ Coverage   82.85%   82.90%   +0.04%     
==========================================
  Files          40       40              
  Lines        3640     3638       -2     
==========================================
  Hits         3016     3016              
+ Misses        510      509       -1     
+ Partials      114      113       -1     
Files Changed Coverage Δ
client/index.go 78.12% <ø> (+1.20%) ⬆️

Signed-off-by: SimFG <bang.fu@zilliz.com>
@mergify mergify bot added the ci-passed auto merge needed label label Aug 14, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Aug 14, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Aug 14, 2023
@sre-ci-robot sre-ci-robot merged commit dd5a31f into milvus-io:master Aug 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants