Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty index type param #559

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

congqixia
Copy link
Contributor

See also #555
/kind bug

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/bug Something isn't working label Aug 21, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/XS Denotes a PR that changes 0-9 lines. labels Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #559 (d3013ef) into master (ac87394) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #559   +/-   ##
=======================================
  Coverage   82.91%   82.92%           
=======================================
  Files          40       40           
  Lines        3653     3654    +1     
=======================================
+ Hits         3029     3030    +1     
  Misses        510      510           
  Partials      114      114           
Files Changed Coverage Δ
entity/index.go 100.00% <100.00%> (ø)

@mergify mergify bot added the ci-passed auto merge needed label label Aug 21, 2023
@yah01
Copy link
Member

yah01 commented Aug 21, 2023

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Aug 21, 2023
@sre-ci-robot sre-ci-robot merged commit 99befb5 into milvus-io:master Aug 21, 2023
6 checks passed
@congqixia congqixia deleted the check_empty_idxtype branch August 21, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/bug Something isn't working lgtm look good to me size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants