Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support milvus-backup #567

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

wayblink
Copy link
Contributor

@wayblink wayblink commented Aug 28, 2023

Signed-off-by: wayblink <anyang.wang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #567 (9a40318) into master (9124e54) will decrease coverage by 0.09%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage   82.87%   82.79%   -0.09%     
==========================================
  Files          40       40              
  Lines        3620     3626       +6     
==========================================
+ Hits         3000     3002       +2     
- Misses        507      511       +4     
  Partials      113      113              
Files Changed Coverage Δ
client/client.go 28.94% <ø> (ø)
client/options.go 57.14% <0.00%> (-3.14%) ⬇️
client/insert.go 79.57% <87.50%> (+0.14%) ⬆️

@mergify mergify bot added the ci-passed auto merge needed label label Aug 28, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Aug 30, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Aug 30, 2023
@sre-ci-robot sre-ci-robot merged commit eb96097 into milvus-io:master Aug 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants