Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SCANN index type used ivf_flat value #597

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

congqixia
Copy link
Contributor

See also #594
/kind bug

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/bug Something isn't working label Oct 16, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/S Denotes a PR that changes 10-29 lines. labels Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #597 (dccf3a8) into master (b1c9ccb) will not change coverage.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #597   +/-   ##
=======================================
  Coverage   82.92%   82.92%           
=======================================
  Files          40       40           
  Lines        3643     3643           
=======================================
  Hits         3021     3021           
  Misses        511      511           
  Partials      111      111           
Files Coverage Δ
entity/indexes_gen.go 99.25% <100.00%> (ø)
entity/indexes_search_param_gen.go 98.34% <ø> (ø)

@mergify mergify bot added the ci-passed auto merge needed label label Oct 16, 2023
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Oct 16, 2023
@sre-ci-robot sre-ci-robot merged commit 647ef31 into milvus-io:master Oct 16, 2023
7 checks passed
@congqixia congqixia deleted the fix_scann_idxtype branch October 16, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/bug Something isn't working lgtm look good to me size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants