Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SDK Version & milvus-proto/go-api to v2.3.2 #606

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

congqixia
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Oct 24, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/M Denotes a PR that changes 30-99 lines. labels Oct 24, 2023
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #606 (90c1ad3) into master (647cbab) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #606   +/-   ##
=======================================
  Coverage   82.85%   82.85%           
=======================================
  Files          40       40           
  Lines        3640     3640           
=======================================
  Hits         3016     3016           
  Misses        512      512           
  Partials      112      112           

@mergify mergify bot added the ci-passed auto merge needed label label Oct 24, 2023
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Oct 26, 2023
@sre-ci-robot sre-ci-robot merged commit 18efb15 into milvus-io:master Oct 26, 2023
7 checks passed
ThreadDao pushed a commit to ThreadDao/milvus-sdk-go that referenced this pull request Nov 1, 2023
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
ThreadDao pushed a commit to ThreadDao/milvus-sdk-go that referenced this pull request Nov 6, 2023
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants