Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Bump SDK & proto version to v2.3.5 #658

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

congqixia
Copy link
Contributor

/kind improvement

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jan 17, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/XS Denotes a PR that changes 0-9 lines. labels Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01a80f0) 73.22% compared to head (826a376) 73.22%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           v2.3.x     #658   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files          46       46           
  Lines        4201     4201           
=======================================
  Hits         3076     3076           
  Misses       1023     1023           
  Partials      102      102           

@mergify mergify bot added the ci-passed auto merge needed label label Jan 17, 2024
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jan 17, 2024
@sre-ci-robot sre-ci-robot merged commit beb42ed into milvus-io:v2.3.x Jan 17, 2024
7 checks passed
@congqixia congqixia deleted the bump_v2.3.5 branch February 20, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants