Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reapply "feat: support enabling mmap for collection (#632)" (#635) #661

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Reapply "feat: support enabling mmap for collection (#632)" (#635) #661

merged 1 commit into from
Jan 30, 2024

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Jan 30, 2024

This reverts commit 43226a3.

@sre-ci-robot sre-ci-robot added approved review approved size/S Denotes a PR that changes 10-29 lines. labels Jan 30, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024 •
edited
Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (3800770) 73.52% compared to head (bf63d34) 73.39%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
- Coverage   73.52%   73.39%   -0.14%     
==========================================
  Files          47       47              
  Lines        4333     4341       +8     
==========================================
  Hits         3186     3186              
- Misses       1034     1042       +8     
  Partials      113      113
Files Coverage Δ
entity/collection_attr.go 70.37% <0.00%> (-29.63%) ⬇️

@yah01
Reapply "feat: support enabling mmap for collection (milvus-io#632)" (m…
bf63d34 
…ilvus-io#635)

This reverts commit 43226a3.

Signed-off-by: yah01 <yang.cen@zilliz.com>
@mergify mergify bot added the ci-passed auto merge needed label label Jan 30, 2024
@congqixia
Copy link
Contributor

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Jan 30, 2024
congqixia
congqixia approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jan 30, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b3abfbe into milvus-io:master Jan 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

Assignees

@congqixia congqixia

Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yah01 @congqixia @sre-ci-robot