Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [Cherry-Pick] Remove varchar column cannot use auto ID constraint (#665) #667

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

congqixia
Copy link
Contributor

No description provided.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/S Denotes a PR that changes 10-29 lines. labels Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (beb42ed) 73.22% compared to head (971fbbd) 73.16%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           v2.3.x     #667      +/-   ##
==========================================
- Coverage   73.22%   73.16%   -0.07%     
==========================================
  Files          46       46              
  Lines        4201     4199       -2     
==========================================
- Hits         3076     3072       -4     
- Misses       1023     1025       +2     
  Partials      102      102              
Files Coverage Δ
client/collection.go 90.56% <ø> (-0.06%) ⬇️

... and 1 file with indirect coverage changes

@mergify mergify bot added the ci-passed auto merge needed label label Feb 20, 2024
@ThreadDao
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Feb 20, 2024
@sre-ci-robot sre-ci-robot merged commit e19ce19 into milvus-io:v2.3.x Feb 20, 2024
7 checks passed
@congqixia congqixia deleted the cp_665 branch February 20, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants