Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support retry on milvus errors and retry on ErrInconsistentRequery #675

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

bigsheeper
Copy link
Contributor

  1. Support retry on milvus errors.
  2. Retry on ErrInconsistentRequery for search and hybrid search operations.

issue: milvus-io/milvus#29656

related milvus pr: milvus-io/milvus#31343

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 75.80645% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 71.96%. Comparing base (1a1a092) to head (f90f01d).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
+ Coverage   71.88%   71.96%   +0.07%     
==========================================
  Files          49       50       +1     
  Lines        4564     4623      +59     
==========================================
+ Hits         3281     3327      +46     
- Misses       1169     1179      +10     
- Partials      114      117       +3     
Files Coverage Δ
merr/errors.go 55.55% <ø> (ø)
client/data.go 64.40% <40.00%> (-0.38%) ⬇️
client/util.go 82.69% <82.69%> (ø)

congqixia added a commit to congqixia/milvus-sdk-go that referenced this pull request Mar 18, 2024
See also milvus-io#675 milvus-io#674

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@mergify mergify bot added the ci-passed auto merge needed label label Mar 18, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Mar 18, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Mar 18, 2024
@sre-ci-robot sre-ci-robot merged commit bede290 into milvus-io:master Mar 18, 2024
7 checks passed
sre-ci-robot pushed a commit that referenced this pull request Apr 12, 2024
…tentRequery" (#717)

revert: #675

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants