Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for fp16, bf16, hybrid search #685

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

ThreadDao
Copy link
Contributor

@ThreadDao ThreadDao commented Mar 22, 2024

  • Add test cases for f616 and bf16 vector type
  • Add test cases for multi-vectors and hybrid search

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.83%. Comparing base (7d66951) to head (f21ccdd).

❗ Current head f21ccdd differs from pull request most recent head 2912551. Consider uploading reports for the commit 2912551 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
- Coverage   71.90%   71.83%   -0.07%     
==========================================
  Files          51       51              
  Lines        4751     4747       -4     
==========================================
- Hits         3416     3410       -6     
- Misses       1211     1214       +3     
+ Partials      124      123       -1     
Files Coverage Δ
client/ann_request.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@ThreadDao ThreadDao force-pushed the advanced-search branch 6 times, most recently from 799276b to 2343344 Compare April 2, 2024 09:17
Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/kind enhancement

@sre-ci-robot sre-ci-robot added kind/enhancement New feature or request lgtm look good to me labels Apr 3, 2024
@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, ThreadDao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Apr 3, 2024
@congqixia congqixia added the ci-passed auto merge needed label label Apr 3, 2024
@sre-ci-robot sre-ci-robot merged commit 6d2bfc9 into milvus-io:master Apr 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants