Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autoindex level check #687

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

chasingegg
Copy link
Contributor

only make sure level > 0, do not check range, range check should be done in the server side

Signed-off-by: chasingegg <chao.gao@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.84%. Comparing base (7ab04e8) to head (acb5cf4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
- Coverage   71.89%   71.84%   -0.05%     
==========================================
  Files          51       51              
  Lines        4746     4746              
==========================================
- Hits         3412     3410       -2     
- Misses       1212     1213       +1     
- Partials      122      123       +1     
Files Coverage Δ
entity/indexes_search_param_gen.go 96.69% <33.33%> (-1.66%) ⬇️

@mergify mergify bot added the ci-passed auto merge needed label label Mar 28, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Mar 29, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Mar 29, 2024
@sre-ci-robot sre-ci-robot merged commit cb6426e into milvus-io:master Mar 29, 2024
7 checks passed
@chasingegg chasingegg deleted the autoindex-level branch March 29, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants