Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filter index info base on provided field name #690

Merged

Conversation

congqixia
Copy link
Contributor

See also #689

See also milvus-io#689

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 April 1, 2024 09:55
@sre-ci-robot sre-ci-robot added the approved review approved label Apr 1, 2024
@congqixia
Copy link
Contributor Author

/kind bug

@sre-ci-robot sre-ci-robot added kind/bug Something isn't working size/XS Denotes a PR that changes 0-9 lines. labels Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.81%. Comparing base (d43cd42) to head (fac629c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
- Coverage   71.84%   71.81%   -0.04%     
==========================================
  Files          51       51              
  Lines        4746     4748       +2     
==========================================
  Hits         3410     3410              
- Misses       1213     1214       +1     
- Partials      123      124       +1     
Files Coverage Δ
client/index.go 75.83% <0.00%> (-1.04%) ⬇️

@mergify mergify bot added the ci-passed auto merge needed label label Apr 1, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Apr 1, 2024
@sre-ci-robot sre-ci-robot merged commit 3eabbb5 into milvus-io:master Apr 1, 2024
7 checks passed
@congqixia congqixia deleted the fix/filter_index_fieldname branch April 11, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/bug Something isn't working lgtm look good to me size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants