Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass offset param in rerank params for HybridSearch #737

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

congqixia
Copy link
Contributor

See also milvus-io/milvus#32562

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot requested a review from sunby April 26, 2024 02:02
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested a review from yah01 April 26, 2024 02:02
@sre-ci-robot sre-ci-robot added approved review approved size/XS Denotes a PR that changes 0-9 lines. labels Apr 26, 2024
Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Apr 26, 2024
@congqixia
Copy link
Contributor Author

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Something isn't working label Apr 26, 2024
@mergify mergify bot added the ci-passed auto merge needed label label Apr 26, 2024
@ThreadDao
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Apr 26, 2024
@sre-ci-robot sre-ci-robot merged commit b8a1b6d into milvus-io:master Apr 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/bug Something isn't working lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants