Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename loadCollectionSync => loadCollection #327

Merged
merged 3 commits into from
Jun 20, 2024
Merged

rename loadCollectionSync => loadCollection #327

merged 3 commits into from
Jun 20, 2024

Conversation

shanghaikid
Copy link
Contributor

this resolve #325

Signed-off-by: shanghaikid <jiangruiyi@gmail.com>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.72%. Comparing base (c9c07f7) to head (7690018).

Files Patch % Lines
milvus/grpc/Collection.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
- Coverage   96.90%   96.72%   -0.19%     
==========================================
  Files          43       43              
  Lines        2651     2655       +4     
  Branches      652      653       +1     
==========================================
- Hits         2569     2568       -1     
- Misses         76       81       +5     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanghaikid shanghaikid merged commit 3bcb585 into main Jun 20, 2024
2 of 5 checks passed
@shanghaikid shanghaikid deleted the node-325 branch June 20, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace loadCollection with loadCollectionSync
2 participants