enhance: proxy check hnsw with sparse is legal

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
milvus-io · Jun 6, 2024 · 3f3d8fa · 3f3d8fa
1 parent 4dd0c54
commit 3f3d8fa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/pkg/util/indexparamcheck/hnsw_checker.go b/pkg/util/indexparamcheck/hnsw_checker.go
@@ -32,9 +32,8 @@ func (c hnswChecker) CheckTrain(params map[string]string) error {
 }
 
 func (c hnswChecker) CheckValidDataType(dType schemapb.DataType) error {
-	// TODO(SPARSE) we'll add sparse vector support in HNSW later in cardinal
-	if !typeutil.IsDenseFloatVectorType(dType) {
-		return fmt.Errorf("HNSW only support float vector data type")
+	if !typeutil.IsVectorType(dType) {
+		return fmt.Errorf("can't build hnsw in not vector type.")
 	}
 	return nil
 }

diff --git a/pkg/util/indexparamcheck/hnsw_checker_test.go b/pkg/util/indexparamcheck/hnsw_checker_test.go
@@ -158,7 +158,7 @@ func Test_hnswChecker_CheckValidDataType(t *testing.T) {
 		},
 		{
 			dType:    schemapb.DataType_BinaryVector,
-			errIsNil: false,
+			errIsNil: true,
 		},
 	}